-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added dark mode to sidebar #35
Conversation
Deploy request for gatsby-portfolio-dev pending review. Review with commit 4dc50c9 |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/smakosh/gatsby-portfolio-dev/j7qwtnocd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use the same dark color used on the body? Also could you take care of the burger icon & sun icon?
Yeah ok I'll take care of that |
Oh yes but I don't think we can do that. FYI I'm not very good with svg's. example: |
You can convert the svg icons to a React component and pass the color as a prop |
you don't even have to go with this as when ever it's dark it's the sun icon showing, so you can just update its color on the svg file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for the contribution @kronicom 🎉
Another small tweak.