Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to change SvxReflector parameters on runtime #572

Closed
wants to merge 24 commits into from

Conversation

dl1hrc
Copy link
Contributor

@dl1hrc dl1hrc commented Jan 30, 2022

Introduce a new branch "reflector-ptyctrl" following an idea from Jens/DJ1JAY to change some SvxReflector parameters on runtime.
For special cases it would be useful if you could change certain parameters of the SvxReflector at runtime without having to restart it. The pseudo tty interface is an ideal approach in my opinion, not just for this case. Please check if this approach is acceptable when you have a chance, thank you.
Mni 73s de Adi / DL1HRC

@RichNeese
Copy link
Contributor

Please rebuild your commit without all the branch merges. to make it a cleaner commit and easier to test

@dl1hrc
Copy link
Contributor Author

dl1hrc commented Jul 25, 2022

I think it makes no sense to continue developing here, since extensions remain uncommented. Pull requests are also not considered and there is no discussion about further extensions. I'm thinking about deleting all my branch and going on to other things. It's a pity, but it probably can't be changed.
Mni 73s de Adi / DL1HRC

@RichNeese
Copy link
Contributor

RichNeese commented Jul 27, 2022 via email

@sm0svx sm0svx self-requested a review March 30, 2024 17:40
@sm0svx sm0svx self-assigned this Mar 30, 2024
- Rename config var CTRL_PTY to COMMAND_PTY to match SvxLink server
- Use similar command parser as in SvxLink server
- Set PTY to be line buffered
- Use the Async::Config::valueUpdated mechanism
- Write command response to PTY
@sm0svx
Copy link
Owner

sm0svx commented Mar 30, 2024

New command structure implemented, similar to the one used in SvxLink server, so to set a config variable use: CFG section tag value. Example: echo CFG GLOBAL SQL_TIMEOUT 500 > /dev/shm/svxreflector-cmd.

Actually any config variable can be set using the CFG command but it's not certain that the reflector will care about it being set at runtime since most config variables are only read at startup. This pull request specifically add support for setting GLOBAL/SQL_TIMEOUT and GLOBAL/SQL_TIMEOUT_BLOCKTIME. It's also possible to set USERS/callsign and PASSWORDS/pwname to a new value, or even add new ones. No changes will be written back to the configuration file though so all changes are only valid until the reflector is restarted.

To see command responses use a command like this for example: socat /dev/shm/svxreflector-ctrl -.

sm0svx added a commit that referenced this pull request Mar 30, 2024
- Rename config var CTRL_PTY to COMMAND_PTY to match SvxLink server
- Use similar command parser as in SvxLink server
- Set PTY to be line buffered
- Use the Async::Config::valueUpdated mechanism
- Write command response to PTY
sm0svx added a commit that referenced this pull request Mar 30, 2024
@sm0svx sm0svx removed their request for review March 30, 2024 21:42
@sm0svx
Copy link
Owner

sm0svx commented Mar 30, 2024

Rebased and merged in commit 5636dff

@sm0svx sm0svx closed this Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants