Add floor, shape_of and squeeze patterns #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchigarev
approved these changes
Nov 19, 2024
dchigarev
reviewed
Nov 19, 2024
Comment on lines
+104
to
+106
| // Rewrite shape ops in tensor/arith/etc | ||
| pm.addPass(createConvertShapeToStandardPass()); | ||
|
|
There was a problem hiding this comment.
will we need the same in the GC pipeline?
There was a problem hiding this comment.
Not if we only feed it with statically shaped batches. In any case, adding it should be a single-line change, so we can just add it.
zhczhong
approved these changes
Nov 20, 2024
kurapov-peter
force-pushed
the
pakurapo/floor-squeeze
branch
from
b772674
to
2021619
Compare
github-actions
bot
removed
category: Python API
category: build
category: packaging
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #174