Skip to content

Commit

Permalink
Correctly handle templated tree artifacts in the prefetcher.
Browse files Browse the repository at this point in the history 
Due to the existence of templated tree artifacts (tree artifacts where each file is produced by a separate action) and nested artifacts (artifacts whose output path is a descendant of another artifact's), the prefetcher must not assume every tree artifact is fetched as a whole.

In addition, concurrent actions calling the prefetcher might write to the same directory in the output tree, so they must synchronize when making the directory temporarily writable.

Fixes bazelbuild#16333.

PiperOrigin-RevId: 513205572
Change-Id: I827c4643643f63c9425e63bdf9177805c5f0f409
  • Loading branch information
@tjgq @copybara-github
tjgq authored and copybara-github committed Mar 1, 2023
1 parent 05d8a6f commit 52deefe
Show file tree
Hide file tree
Showing 4 changed files with 375 additions and 266 deletions.
Loading

0 comments on commit 52deefe

Please sign in to comment.