Enhancement: Add PHP-CS-Fixer #31
Conversation
| @@ -1,28 +1,35 @@ | |||
| { | |||
There was a problem hiding this comment.
It also executes "composer normalize"
OskarStark
force-pushed
the
feature/php-cs-fixer
branch
from
e49c2d9
to
11f571f
Compare
| 'declare_strict_types' => false, | ||
| 'void_return' => false, | ||
| 'ordered_imports' => false, | ||
| 'php_unit_test_case_static_method_calls' => false, | ||
| 'strict_comparison' => false, | ||
| 'yoda_style' => false, | ||
| 'phpdoc_to_property_type' => false, | ||
| 'phpdoc_summary' => false, | ||
| 'nullable_type_declaration_for_default_null_value' => false, |
There was a problem hiding this comment.
I will activate and execute them, once this PR is merged.
| @@ -32,9 +32,17 @@ jobs: | |||
| extensions: "${{ env.REQUIRED_PHP_EXTENSIONS }}" | |||
| tools: "composer:v2" | |||
|
|
|||
| - name: "Composer install" | |||
| uses: "ramsey/composer-install@v1" | |||
There was a problem hiding this comment.
can be upgraded to v3 across the whole file afterwards
|
Thanks @OskarStark , I will review later. |
|
Any news here? |
| */ | ||
| private $recipient; | ||
|
|
||
| /** | ||
| * @var GlanceDataFields Glance Data Fields. | ||
| * @var GlanceDataFields glance Data Fields | ||
| */ |
There was a problem hiding this comment.
Is it possible to go through such changes, review them and move description to the top please? E.g.:
/**
* Glance Data Fields
*
* @var GlanceDataFields
*/
There was a problem hiding this comment.
Will check in the next days
There was a problem hiding this comment.
This will be moved anyway when we add native types. From this point on it is superfluous for Cs-Fixer and it will be removed, resulting in the plain description as comment.
Sorry, busy couple of days, completely forgot about it. Overall I am ok with all the changes. Do we need to update |
|
So ready to merge from my side |
|
Will create follow up PRs soon 🤞🏻✌🏻 |
|
Thank you @OskarStark :) |
With this PR, everyone is able to execute
make cs@slunak best reviews commit by commit, as the first one introduces the config and the second one executes the PHP-CS-Fixer