Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css: distinguish multi-line entries in nav bar #840

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

MarkLodato
Copy link
Member

@MarkLodato MarkLodato commented Apr 14, 2023

Previously the nav bar did not have any visual distinction between two different entries vs one entry with multiple lines - they all ran together.

Now there is slightly more whitespace between entries and slightly less whitespace between lines within an entry, with all other spacing being almost pixel equivalent.

Note: 0fa8c9d did this for the TOC, without being as careful about pixel equivalence.

To preview, compare "Verifying build platforms" and "For infrastructure providers" in the screenshots below, or flip back and forth between the netlify preview and the live site.

Before After
before after

Previously the nav bar did not have any visual distinction between two
different entries vs one entry with multiple lines - they all ran
together.

Now there is slightly more whitespace between entries and slightly less
whitespace between lines within an entry, with all other spacing being
*almost* pixel equivalent.

Note: 0fa8c9d did this for the TOC, without being as careful about pixel
equivalence.

Signed-off-by: Mark Lodato <[email protected]>
@netlify
Copy link

netlify bot commented Apr 14, 2023

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit a1625b2
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/64396df746f2620008f811ec
😎 Deploy Preview https://deploy-preview-840--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't pretend to understand the CSS, but the results look good to me.

@MarkLodato MarkLodato merged commit 21da59f into slsa-framework:main Apr 17, 2023
@MarkLodato MarkLodato deleted the nav-line-height branch April 17, 2023 12:22
Copy link
Member

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants