Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: draft: Update threat-overview table to use new threat diagram #1209

Merged
merged 11 commits into from
Oct 24, 2024

Conversation

TomHennen
Copy link
Contributor

The existing threats-overview page uses the old SLSA threats diagram, so the lettering was off and some threats were not addressed.

This update fixes the lettering, updates the language to use the terms used on the diagram, and adds missing threats.

fixes #1208

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit 56efe13
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/671915db8d8cc90008837c36
😎 Deploy Preview https://deploy-preview-1209--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, you're on a roll! That's great!
Just a couple of suggestions, LGTM otherwise.

docs/spec/draft/threats-overview.md Outdated Show resolved Hide resolved
docs/spec/draft/threats-overview.md Outdated Show resolved Hide resolved
TomHennen and others added 2 commits October 17, 2024 16:51
Co-authored-by: Arnaud J Le Hors <[email protected]>
Signed-off-by: Tom Hennen <[email protected]>
Co-authored-by: Arnaud J Le Hors <[email protected]>
Signed-off-by: Tom Hennen <[email protected]>
@TomHennen
Copy link
Contributor Author

Man, you're on a roll! That's great! Just a couple of suggestions, LGTM otherwise.

It's amazing what you can get done when you have a few spare hours and not very much email...

Copy link
Member

@mlieberman85 mlieberman85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

docs/spec/draft/threats-overview.md Show resolved Hide resolved
docs/spec/draft/threats-overview.md Outdated Show resolved Hide resolved
docs/spec/draft/threats-overview.md Show resolved Hide resolved
docs/spec/draft/threats-overview.md Outdated Show resolved Hide resolved
docs/spec/draft/threats-overview.md Show resolved Hide resolved
docs/spec/draft/threats-overview.md Show resolved Hide resolved
…y the XZ _project_ was malicious, just one of the maintainers.

Signed-off-by: Tom Hennen <[email protected]>
Signed-off-by: Tom Hennen <[email protected]>
@TomHennen
Copy link
Contributor Author

Ok, I think this is probably GTG. I'll leave it to sit for another day before submitting.

@TomHennen TomHennen merged commit adbc0b1 into slsa-framework:main Oct 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Threats overview page needs to be updated for 1.1
5 participants