Refactor - Use interface for rekor #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveensrinivasan
force-pushed
the
naveen/feat/refactor-rekorinterface
branch
from
bcb26d3 to
4b06a74
Compare
naveensrinivasan
changed the title
- Use rekor interface instead of concrete implementation so that it can be mocked and tested. - Included the mock for the interfaces that will be used for unit testing the methods that doesn't have test coverage. Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan
force-pushed
the
naveen/feat/refactor-rekorinterface
branch
from
4b06a74 to
6b39a16
Compare
ianlewis
reviewed
Aug 2, 2022
| ) | ||
|
|
||
| // MockEntriesClientService is a mock of ClientService interface. | ||
| type MockEntriesClientService struct { |
There was a problem hiding this comment.
Maybe provide a Makefile target or instructions somewhere on how to regenerate these?
| @@ -0,0 +1,124 @@ | |||
| package pkg | |||
There was a problem hiding this comment.
Put generated mocks in a separate package.
|
I'm going to close this as it's pretty old. Feel free to resubmit the PR if we need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
be mocked and tested.
Signed-off-by: naveensrinivasan [email protected]