Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update go to 1.21 #738
fix(deps): update go to 1.21 #738
Changes from 18 commits
efb06f1
9876215
c53cef4
5bfa9a1
55946d3
03b19ee
a689248
7d3f4ed
9caa024
5f72541
4504b4a
0ad7ac8
c632f95
ed8710a
bf1cca9
85d3835
f2d691f
ecdf74b
5d014d0
f58fd9e
d2501dc
e2889ed
00ba1b3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the issue with using
go-version-file
before? I guess we fixed it in1.9.0
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what the issue was before, but using
go-version-file
instead ofgo-version
lets use specify which version to use in only one place.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I remember we fixed an issue with it and maybe that was in
1.9.0
?slsa-framework/slsa-github-generator#2661
But it looks like we haven't released that fix yet.
slsa-framework/slsa-github-generator@00c744f