-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add secure-checkout action #971
Conversation
Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Ian Lewis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Assuming you'll move over checkouts in checkout-* in another PR and update the presubmit
Yep. I need to get the action checked in before I can reference it so I'll send a follow up PR. Thanks for the review! |
Updates #968
Updates #795
Adds a
secure-checkout
action to replace the existingverify-checkout
action.verify-checkout
checked if the checked out commit matchedGITHUB_SHA
which doesn't work if checking out the builder repo like thegenerate-builder
action does which causes failures.secure-checkout
instead wraps theactions/checkout
and forces the user to specify a git sha1 digest to check out and verifies that the checked out commit is the expected commit.