Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secure-checkout action #971

Merged
merged 10 commits into from
Oct 11, 2022
Merged

Conversation

ianlewis
Copy link
Member

@ianlewis ianlewis commented Oct 7, 2022

Updates #968
Updates #795

Adds a secure-checkout action to replace the existing verify-checkout action.

verify-checkout checked if the checked out commit matched GITHUB_SHA which doesn't work if checking out the builder repo like the generate-builder action does which causes failures.

secure-checkout instead wraps the actions/checkout and forces the user to specify a git sha1 digest to check out and verifies that the checked out commit is the expected commit.

@ianlewis ianlewis marked this pull request as ready for review October 7, 2022 09:27
Copy link
Collaborator

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Assuming you'll move over checkouts in checkout-* in another PR and update the presubmit

.github/workflows/scripts/pre-submit.actions/checkout.sh Outdated Show resolved Hide resolved
@ianlewis
Copy link
Member Author

LGTM!

Assuming you'll move over checkouts in checkout-* in another PR and update the presubmit

Yep. I need to get the action checked in before I can reference it so I'll send a follow up PR. Thanks for the review!

@ianlewis ianlewis enabled auto-merge (squash) October 11, 2022 20:07
@ianlewis ianlewis merged commit 5d257ff into slsa-framework:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants