-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add privacy-check action #836
Add privacy-check action #836
Conversation
Signed-off-by: Ian Lewis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'd like to have #823 (comment) resolved before merging.
I think we need explicit opt- in from users who have private repos, otherwise we're leaking their repo name silently.
This is because the repo name appears in on the rekor transparency log? (probably another good reason why repo metadata on the cert isn't a great solution). |
From #823 (comment) by @laurentsimon
That's a good catch. Private PKI and transparency log can be supported more properly via #34 #823 (comment) by @laurentsimon
I'll update this PR to support |
Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Ian Lewis <[email protected]>
…te-and-sign-provenance
@laurentsimon I updated this PR to just add a new Permissions on workflows are not changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Please add a pre-submit to verify the "compilation" step gives the right dist
output.
Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Ian Lewis <[email protected]>
Updates #823
Adds a
privacy-check
action to the repo. The action checks if the repository is private and fails if it is. Users can override this by explicitly setting theoverride
input.Workflows will use this action to check if repos are private in a subsequent PR because the action needs to be referenced by sha.
Signed-off-by: Ian Lewis [email protected]