Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update softprops/action-gh-release digest to 50195ba - autoclosed #482

Conversation

renovate-bot
Copy link
Contributor

Mend Renovate

This PR contains the following updates:

Package Type Update Change
softprops/action-gh-release action digest 1e07f43 -> 50195ba

Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

Copy link
Member

@ianlewis ianlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only upgrade to tagged releases.

@laurentsimon
Copy link
Collaborator

laurentsimon commented Jul 4, 2022

I'm in favor of discarding updates to this Action. It's a 3P action with write access, and we to replace it with our own code anyway.

Do you know why renovatebot sends PR for non-tagged releases? It should not be doing that, and especially not with the default config.

/cc @rarkins can you advise?

@rarkins
Copy link
Contributor

rarkins commented Jul 4, 2022

I don't think that should happen. Taking a look

@rarkins
Copy link
Contributor

rarkins commented Jul 4, 2022

Please see #489 for the fix. Merging it will mean any digest update PRs will be autoclosed afterwards. Renovate requires use of the # tag=v1.2.3 approach instead of # v1.2.3. This was chosen so as to reduce the chances of false positive and allow non-version tags to be pinned too (e.g. # tag=stable).

@renovate-bot renovate-bot changed the title Update softprops/action-gh-release digest to 50195ba Update softprops/action-gh-release digest to 50195ba - autoclosed Jul 5, 2022
@renovate-bot renovate-bot deleted the renovate/softprops-action-gh-release-digest branch July 5, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants