feat: workflow to update actions dist #3653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
ramonpetgrave64
requested review from
laurentsimon,
joshuagl and
kpk47
as code owners
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
ianlewis
reviewed
May 15, 2024
| @@ -97,8 +97,8 @@ jobs: | |||
|
|
|||
| - name: actionlint | |||
| env: | |||
| ACTIONLINT_VERSION: "1.6.24" | |||
| ACTIONLINT_CHECKSUM: "3c5818744143a5d6754edd3dcc4c2b32c9dfcdd3bb30e0e108fb5e5c505262d4" | |||
| ACTIONLINT_VERSION: "1.7.0" | |||
There was a problem hiding this comment.
Nice. 1.7.0 has initial support for GitHub actions actions.yml and not just workflows.
https://github.com/rhysd/actionlint/releases/tag/v1.7.0
ianlewis
approved these changes
May 15, 2024
| permissions: {} | ||
|
|
||
| on: | ||
| workflow_dispatch: |
There was a problem hiding this comment.
nit: I think we typically have 2 space indentation for the yaml files though it looks like the linter doesn't currently enforce it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similar to slsa-verifier's slsa-framework/slsa-verifier#760
This PR adds a manually-invoked workflow to run against renovate-bot's PRs to update the node
distfolders.I made one small change to use the
${{ inputs.pr_number }}as an environment variable, to harden against script injection. See also slsa-framework/slsa-verifier#771Also updating shellckeck to fix this lint error:
Testing Process
I ran this against my fork's version of PR #3649. It did update the dist folders and the check-dists checks pass
Checklist