Refactor - Use interface for rekor and fulcio #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveensrinivasan
requested review from
asraa,
ianlewis,
laurentsimon and
joshuagl
as code owners
naveensrinivasan
force-pushed
the
naveen/feat/refactor-provenancegeneration
branch
from
799449d to
324f41e
Compare
- Refactored the implementation to accept the interface instead of the concrete implementation within the function. - With this change `GenerateProvenance` can be tested with mocks. At the moment there aren't any unit tests for `GenerateProvenance`. Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan
force-pushed
the
naveen/feat/refactor-provenancegeneration
branch
from
324f41e to
2fa67a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the implementation to accept the interface instead of the
concrete implementation within the function.
With this change
GenerateProvenancecan be tested with mocks. At themoment there aren't any unit tests for
GenerateProvenance.Signed-off-by: naveensrinivasan [email protected]