Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): use go1.21 #3179

Conversation

ramonpetgrave64
Copy link
Collaborator

@ramonpetgrave64 ramonpetgrave64 commented Jan 25, 2024

Similar to the work in slsa-framework/slsa-verifier#738, we're upgrading to go1.21.

Also following up in slsa-framework/example-package#303

Signed-off-by: Ramon Petgrave <[email protected]>
@ramonpetgrave64
Copy link
Collaborator Author

@laurentsimon @ianlewis

Copy link
Collaborator

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's wait till all the e2e issues have been closed before merging this one.

@ramonpetgrave64
Copy link
Collaborator Author

It seems like most of them auto-closed overnight, but a few are left open or failed again. I'll check those
https://github.com/slsa-framework/slsa-github-generator/issues?q=is%3Aissue+is%3Aclosed

@laurentsimon
Copy link
Collaborator

Can you rebase? Are we ready to merge this PR?

@ramonpetgrave64
Copy link
Collaborator Author

I rebased, and theres no longer any diff. It looks like @haydentherapper got all the right changes included in his PR to bump cosign
#3355

@laurentsimon
Copy link
Collaborator

sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants