Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bazel): use secure-folder-upload and temp dir #2397

Merged
merged 14 commits into from
Jul 24, 2023

Conversation

enteraga6
Copy link
Collaborator

@enteraga6 enteraga6 commented Jul 18, 2023

cc/ @mihaimaruseac

closes #2276
closes #2331

This switches the folder upload from the actions/upload-artifact to our secure-upload-folder @ v1.7.0.

This also strengthens the name of the folder that is uploaded to avoid collisions. Since the path to folder cannot be in /tmp with the secure-upload-folder, the name of the folder being upload was changed from binaries to bazel_builder_binaries_to_upload_to_gh to avoid any potential name collisions and be able to utilize the secure-upload-folder action.

@enteraga6 enteraga6 changed the title [chore][bazel] use secure-folder-upload and temp dir chore(bazel) use secure-folder-upload and temp dir Jul 18, 2023
@enteraga6 enteraga6 changed the title chore(bazel) use secure-folder-upload and temp dir chore(bazel): use secure-folder-upload and temp dir Jul 18, 2023
@enteraga6
Copy link
Collaborator Author

cc/ @laurentsimon

internal/builders/bazel/build.sh Outdated Show resolved Hide resolved
@laurentsimon laurentsimon enabled auto-merge (squash) July 24, 2023 18:27
@laurentsimon laurentsimon merged commit afac386 into slsa-framework:main Jul 24, 2023
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants