Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add commands to nodejs builder #1189

Merged
merged 3 commits into from
Nov 4, 2022

Conversation

laurentsimon
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this is just template work right now? If so LGTM, maybe just add some example usage or start the README.md with the expected commands.

internal/builders/nodejs/ci.go Outdated Show resolved Hide resolved
Long: `Generate SLSA provenance for Github Actions.
For more information on SLSA, visit https://slsa.dev`,
RunE: func(cmd *cobra.Command, args []string) error {
return errors.New("expected command")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe print Usage string provided by cobra?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does it automatically, it seems

@laurentsimon
Copy link
Collaborator Author

I'm guessing this is just template work right now? If so LGTM, maybe just add some example usage or start the README.md with the expected commands.

correct, just the template for the command we need. I'll add README info.

@ianlewis ianlewis changed the title feat: add comnands to nodejs builder feat: add commands to nodejs builder Nov 4, 2022
@laurentsimon laurentsimon enabled auto-merge (squash) November 4, 2022 07:51
@laurentsimon laurentsimon merged commit 54c1f58 into slsa-framework:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants