-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add commands to nodejs builder #1189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this is just template work right now? If so LGTM, maybe just add some example usage or start the README.md with the expected commands.
Long: `Generate SLSA provenance for Github Actions. | ||
For more information on SLSA, visit https://slsa.dev`, | ||
RunE: func(cmd *cobra.Command, args []string) error { | ||
return errors.New("expected command") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe print Usage string provided by cobra?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does it automatically, it seems
correct, just the template for the command we need. I'll add README info. |
12928f8
to
f0a8874
Compare
No description provided.