-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ref for internal action calls #1075
Conversation
@ianlewis appreciate feedback and questions, since this seems to undo some of the secure-checkout code. I want to be sure I'm not mis-understanding something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, after I understand now the user risk and interaction here.
if [[ "$GITHUB_EVENT_NAME" == "pull_request" ]]; then | ||
github_sha="$PULL_REQUEST_SHA" | ||
fi | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laurentsimon Since you mentioned actions/checkout
pulls a tar, I wondered if that tar could somehow be overwritten with a dirty checkout such that git log -1 --format='%H'
returns the right SHA but the checkout itself it dirty and contains different code.
Maybe not necessary for this PR but we could maybe add a check for git status
or git diff
in the future.
I think this is fine. I wasn't totally confident |
Related #626 |
68da1f5
to
b076bdb
Compare
Remove the ref we use to call internal actions, Instead, checkout the builder repo and calls them locally.
closes #880