Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] add eslint linter #610

Closed
1 of 4 tasks
ianlewis opened this issue Jul 22, 2022 · 2 comments · Fixed by #792
Closed
1 of 4 tasks

[feature] add eslint linter #610

ianlewis opened this issue Jul 22, 2022 · 2 comments · Fixed by #792
Assignees
@naveensrinivasan
Labels
area:tooling An issue with project tooling and config type:feature New feature or request

Comments

@ianlewis
Copy link
Member

ianlewis commented Jul 22, 2022 •
edited
Loading

If we are going to have actions written in Typescript we should probably lint the code using eslint with typescript-eslint

Related #546 #398
@ianlewis ianlewis added type:feature New feature or request area:tooling An issue with project tooling and config labels Jul 22, 2022
@naveensrinivasan
Copy link
Collaborator

I can work on this.

@naveensrinivasan naveensrinivasan self-assigned this Jul 27, 2022
naveensrinivasan added a commit to naveensrinivasan/slsa-github-generator that referenced this issue Jul 28, 2022
@naveensrinivasan
Included typescript-eslint
41fba60 
- Included typescript-eslint
- This is based on https://github.com/actions/typescript-action
- Fixes slsa-framework#610

Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan added a commit to naveensrinivasan/slsa-github-generator that referenced this issue Jul 28, 2022
@naveensrinivasan
Included typescript-eslint
0cfdcf0 
- Included typescript-eslint
- This is based on https://github.com/actions/typescript-action
- Fixes slsa-framework#610

Signed-off-by: naveensrinivasan <[email protected]>
@naveensrinivasan naveensrinivasan mentioned this issue Jul 28, 2022
Merged
@ianlewis
Copy link
Member Author

ianlewis commented Sep 6, 2022

Reopen to add support to Makefile and presubmits

@ianlewis ianlewis reopened this Sep 6, 2022
@ianlewis ianlewis mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naveensrinivasan naveensrinivasan

Labels
area:tooling An issue with project tooling and config type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Makefiles ianlewis/slsa-github-generator
2 participants
@ianlewis @naveensrinivasan