Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
here is another attempt at updating tokio to v1.
Some remarks:
tokio-serial
withserial-io
, a custom fork I made based onmio-serial
andtokio-serial
. It basically just adds tokio v1 support via a feature flag instead of splitting it into different crates. Also all other dependencies have been updated. I checked this PR and made sure that I fixed this.serial-io
is slightly different.Serial
toAsyncSerial
, because the regularSerial
inserial-io
has no tokio support. I'm not sure, if I should change the name.Changelog:
closes #71 and #72