-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GPU #37
base: master
Are you sure you want to change the base?
Enable GPU #37
Conversation
Hey Rajesh, thanks for the pull request! This looks interesting. Have you tested that it works as expected? Do you get similar results with GPU set to True or False? Could you share any benchmarking results that might help users understand the expected benefit from using GPU? Thanks again! |
Sorry, I have not yet completely tested. I should have marked the MR as Draft. I will get back to you soon. |
It is still failing a test. |
All such imports are appended with an underscore. Other changes include a pytest to measure performance.
@slowkow please find a unit test for perf committed(marked skip). While testing with While testing with larger datasets the difference is very noticeable. When the input size is (35922, 25101) it is 10sec vs 73sec. The results are very similar. The difference starts appearing after 2nd decimal place. Please find attached the first 100 lines from the following code.
|
No description provided.