-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add PHP support #57
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sliphq/run-wasm/6qH4giFpB7Y7RriHaM6nNJrBZspE |
I already see it failed on Vercel, but I will be the slowest one to fix it, so I hope someone can help. |
The deploy worked but I'm not seeing the Run Code button for the PHP page |
I'm getting some console errors:
My best guess is that |
Yeah, that’s what I meant when I said I added public files to git. I was not sure if Vercel runs the command, so decided to just add them for now manually. |
Yep, sorry, I was not clear with the failed Vercel. It deployed well, but for some reason can not load the file as I see from console logs. I will try to investigate it and learn Vercel if I have time, but will be happy too if someone solves it😃 |
Is there an approach that wouldn't require adding the files to the public folder? Pyodide is loaded via cdn. Is that an option here @nikolaystrikhar? |
@kennethcassel no, I wish they had it. I also took a look at some other languages and it looks like most of them are not that convenient as pyodide😯 |
In that case I think we should follow an approach like mentioned here from Zack. |
Yes, I absolutely love this approach and we definitely need to go this way, otherwise everything will be monstrous in two weeks. But my idea was to just show that it’s possible with PHP, so maybe we’ll rethink our structure and find the way of implementing it. Better to have something to work with that nothing! |
Great work on showing a proof of concept :) I think to merge yet another language, we need to figure out a pattern for supporting the large wasm modules in a way that's good for the user. So for now, I'm going to close this PR and open an issue for integrating PHP and using the approach that Zach mentioned in #32 |
I made a basic version using php-wasm.
It definitely needs to be improved (feel free to refactor and improve please), but at least the first function works :-)
I'm not sure it was a good idea to add public files to this repo, but I don't understand how Vercel works yet. Please send some help and feel free to make it work :-)