-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for raw-window-handle #4918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `rwh_06` feature to the Rust API crates, which adds support for version 0.6 of rwh to slint::Window, by delegation to the backend. HasDisplayHandle could also be provided on the backend, but that can be done separately if needed. This is only implemented for the winit backend right now. Fixes #877
ogoffart
reviewed
Mar 22, 2024
tronical
commented
Mar 22, 2024
ogoffart
reviewed
Mar 22, 2024
ogoffart
approved these changes
Mar 22, 2024
ogoffart
reviewed
Mar 22, 2024
The Qt backend should also support this, can return something similar to the window_handle_for_qt_window function in examples/cpp/platform_qt/main.cpp |
Right, I'll do the Qt bit in a separate change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
raw-window-handle-06
feature to the Rust API crates, which adds support for version 0.6 of rwh to slint::Window, by delegation to the backend.HasDisplayHandle could also be provided on the backend, but that can be done separately if needed.
Fixes #877