Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rfd for every OS #13

Merged
merged 1 commit into from
Jan 26, 2022
Merged

use rfd for every OS #13

merged 1 commit into from
Jan 26, 2022

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Jan 26, 2022

rfd 0.7 can now use the XDG Desktop Portal D-Bus API instead of
depending on GTK. The D-Bus API is handled by ashpd which uses
zbus, so this does not bring in any new C or C++ dependencies.

rfd 0.7 can now use the XDG Desktop Portal D-Bus API instead of
depending on GTK. The D-Bus API is handled by ashpd which uses
zbus, so this does not bring in any new C or C++ dependencies.
@ogoffart
Copy link
Member

Thanks!

I just tested and the window now appear under all the other window, so we don't see it.
And if we press several time on the button, it will mess things up as only one dialog opens and it re-opens once it is closed.

@ogoffart
Copy link
Member

ogoffart commented Jan 26, 2022

And if we press several time on the button, it will mess things up as only one dialog opens and it re-opens once it is closed.

That bug was already there before, it was just not so visible if the dialog pops up in front.
We should ideally disable the UI when the dialog is shown...

the [dialog] window now appear under all the other window, so we don't see it.

I guess we need to pass a window handle. We should add API in SixtyFPS to get that handle.

@ogoffart
Copy link
Member

Also, dialog.set_directory(directory); doesn't seem to have an effect :-/

@ogoffart ogoffart merged commit 483547a into slint-ui:master Jan 26, 2022
@ogoffart
Copy link
Member

Thanks for the patch!

@Be-ing Be-ing deleted the rfd branch January 26, 2022 16:16
@Be-ing
Copy link
Contributor Author

Be-ing commented Jan 26, 2022

I just tested and the window now appear under all the other window, so we don't see it.

Does SixtyFPS have an API to get a raw_window_handle?

@Be-ing
Copy link
Contributor Author

Be-ing commented Jan 26, 2022

Also, dialog.set_directory(directory); doesn't seem to have an effect :-/

PolyMeilex/rfd#42

@tronical
Copy link
Member

I just tested and the window now appear under all the other window, so we don't see it.

Does SixtyFPS have an API to get a raw_window_handle?

Not yet, but I think that can be added. We've discussed this before and raw-window-handle seems like it offers a stable API, so it might be okay to re-export it.

@Be-ing
Copy link
Contributor Author

Be-ing commented Jan 26, 2022

slint-ui/slint#877

@Be-ing
Copy link
Contributor Author

Be-ing commented Jan 26, 2022

That bug was already there before, it was just not so visible if the dialog pops up in front.
We should ideally disable the UI when the dialog is shown...

Do you think this should be addressed in rfd, in SixtyFPS, or in the SixtyFPS application?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants