Fix for instance culling on Intel GPUs #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! This looks a lot cleaner and thanks for solving and spotting the need for the extra padding - the fix original fix was a bit of a guess into the air as the correct / expected behaviour is sort of undefined, it now seems to cover all the cases! Will run it through the test runner for safety, but expecting it to be sound! |
|
Cool! All tests passed as expected! Thanks again for the good improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
The fix for drawingCoord needs the strides to be a multiple of 32 bytes, but the existing code rounded to 4 uint32_t's, which is 16 bytes. This was working correctly for non-culled drawing because the drawCoords were a multiple of 16 and 32 bytes. But instanced culling threw this off and needed to be padded more.
I also moved things around a little to make it cleaner, but this is purely subjective and optional to the fix.
Fixes Issue(s)