V1.3 #454
Merged
V1.3 #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added .python-version, pyproject.toml, and uv.lock to ignore files
- Improved error handling for invalid certificate values and file paths in the `makeTlsConfig` function. - Added support for PEM-encoded certificates passed directly as values, not just file paths. - Updated the `processValue` function to handle both files and PEM-encoded certificates. - Enhanced error messages to provide more specific information about invalid input. - Added checks to ensure that certificates and keys are properly loaded before creating the TLS config. - Updated unit tests to cover these changes. - Modified existing tests to accommodate changes in the `makeTlsConfig` function. - Ensured that the new error handling and value processing logic functions correctly in both normal and edge cases. - Refactored the code to improve readability and maintainability.
- Removed the `trim_space` option from the `StreamConfig` struct and related functions. - This option was redundant as the trimming of spaces is now handled implicitly based on the column type. - This change simplifies the code and improves maintainability. - Updated related test cases to reflect the removal of the `trim_space` option.
- Removed the `trim_space` option from the sling configuration. - Updated the stream processor to handle empty values more robustly, using `empty_as_null` instead of relying on `trim_space`. - Improved the handling of transforms in the stream processor, adding a dedicated `empty_as_null` transform. - Refactored the `transforms` field in `StreamConfig` to use a `TransformList` instead of a simple array, allowing for more efficient transform lookup. - Updated the test cases to reflect the changes.
- Prevent unnecessary processing when SampleSize is 0 - Prevent unnecessary processing when all columns are coerced to strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Features
Partitioned Parquet Support
Certificate Handling
Hook System Changes
HooksintoPreHooksandPostHooksRemoved Features
trim_spaceconfiguration optionBehavioral Changes
Constraint Handling
SLING_ON_CONSTRAINT_FAILUREcontrols behaviorFile Writing
Database Connections
Other Changes
Configuration
sqlldrandbcpCode Organization