Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the difficulty reaches 10,000, the game may fail to determain the next sacrifice #4

Closed
NeunEinser opened this issue Apr 5, 2019 · 1 comment

Comments

@NeunEinser
Copy link

NeunEinser commented Apr 5, 2019

10,000 is not arbitary, it is the value where the game can only choose a totem of undying by definition (All other items would require an amount of more than 5 at this point). Most of the times, the function newgoal.mcfunction does run more commands than the max chain length, which is set to 100,000 after installation of the datapack. Sometimes it does actually succeed, though.
When setting maxCommandChainLength to 1,000,000, a huge lagspike occurs and while the end of the function is reached (Debug say at the end of it gets executed), no item is chosen.
Possibly an edge case when the list of possible items has a length of 1.

@slicedlime
Copy link
Owner

This happens on day 27, in the current difficulty scaling. I think the reasonable thing to do might be to just start scaling up the number of max items when the value starts getting very high.

slicedlime added a commit that referenced this issue Apr 5, 2019
- Tweaked max item count to 5 instead of 4.
- Allow requests of up to 10 items if difficulty is above 5000.
- Added back nether stars at 8000 value.
- Cap out difficulty at 20000.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants