Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim down data loaded into browsers #115

Open
14 of 18 tasks
stefanb opened this issue Dec 19, 2021 · 4 comments
Open
14 of 18 tasks

Trim down data loaded into browsers #115

stefanb opened this issue Dec 19, 2021 · 4 comments

Comments

@stefanb
Copy link
Member

stefanb commented Dec 19, 2021

Check which columns from https://github.com/sledilnik/zdravniki-data/tree/main/csv are not used and either use them (eg in search) or remove them from cvs

dict-institutions.csv:

  • id_inst
  • zzzsSt (will become a key, when we manage to match everything)
  • name
  • unit ?
  • address
  • post
  • city
  • municipality ?
  • lat,lon
  • phone
  • website

We could also add statistical region name if needed.

doctors.csv:

  • id (synthetic id, not really useful, best to not use it and remove it from CSV)
  • doctor
  • type
  • accepts
  • availability
  • load
  • id_inst
@lukarenko
Copy link
Contributor

@stefanb yes, we should remove id if not used in web - just causes larger diff on updates

@stefanb
Copy link
Member Author

stefanb commented Dec 20, 2021

@jalezi can you confirm that we aren't using id field from doctors.csv?

@jalezi
Copy link
Collaborator

jalezi commented Dec 20, 2021

@jalezi can you confirm that we aren't using id field from doctors.csv?

It needs some changes.. But this is easy fix. Replacing with something unique as doctor.key.
Screenshot 2021-12-20 12 00 24

I'll do it right now. There is a dedicated branch, right?

@jalezi
Copy link
Collaborator

jalezi commented Dec 20, 2021

@stefanb I also have to change 'doctorsContext.js`. This will take some time. I will explain a little bit later.

jalezi added a commit that referenced this issue Dec 20, 2021
doctor.csv will no longer have "id" field

BREAKING CHANGE: #115
jalezi added a commit that referenced this issue Dec 20, 2021
It's ditry solution but will do for now.

BREAKING CHANGE: #115
stefanb pushed a commit that referenced this issue Dec 21, 2021
* feat: 👽️ remove doctor id

doctor.csv will no longer have "id" field

BREAKING CHANGE: #115

* fix: 👽️ use uuid as key for doctors dict

It's ditry solution but will do for now.

BREAKING CHANGE: #115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants