Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch: disable extensive keyspace events logging #554

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Patch: disable extensive keyspace events logging #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions go/vt/discovery/keyspace_events.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,10 +312,12 @@ func (kss *keyspaceState) ensureConsistentLocked() {
Serving: sstate.serving,
})

log.Infof("keyspace event resolved: %s/%s is now consistent (serving: %v)",
sstate.target.Keyspace, sstate.target.Keyspace,
sstate.serving,
)
// Disable it due to log storm in production
// thread https://slack-pde.slack.com/archives/C06CPL4HMED/p1729896804879749
// log.Infof("keyspace event resolved: %s/%s is now consistent (serving: %v)",
// sstate.target.Keyspace, sstate.target.Keyspace,
// sstate.serving,
// )

if !sstate.serving {
delete(kss.shards, shard)
Expand Down
6 changes: 4 additions & 2 deletions go/vt/vtgate/buffer/shard_buffer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,8 +475,10 @@ func (sb *shardBuffer) recordKeyspaceEvent(alias *topodatapb.TabletAlias, stillS
sb.mu.Lock()
defer sb.mu.Unlock()

log.Infof("disruption in shard %s/%s resolved (serving: %v), movetable state %#v",
sb.keyspace, sb.shard, stillServing, keyspaceEvent.MoveTablesState)
// Disable it due to log storm in production
// thread https://slack-pde.slack.com/archives/C06CPL4HMED/p1729896804879749
// log.Infof("disruption in shard %s/%s resolved (serving: %v), movetable state %#v",
// sb.keyspace, sb.shard, stillServing, keyspaceEvent.MoveTablesState)

if !topoproto.TabletAliasEqual(alias, sb.currentPrimary) {
if sb.currentPrimary != nil {
Expand Down
Loading