Refactored query parsing to support all OpenSearch queries #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to handle a wider variety of queries
kyle-sammons
force-pushed
the
ksammons-astra-query-parsing-refactor-part-1
branch
from
ec4bd6b to
c888a75
Compare
bryanlb
requested changes
Jul 12, 2024
astra/src/main/java/com/slack/astra/logstore/opensearch/OpenSearchAdapter.java
Outdated
Show resolved
Hide resolved
astra/src/main/java/com/slack/astra/logstore/opensearch/OpenSearchAdapter.java
Outdated
Show resolved
Hide resolved
astra/src/main/java/com/slack/astra/logstore/search/SearchResultUtils.java
Outdated
Show resolved
Hide resolved
astra/src/test/java/com/slack/astra/elasticsearchApi/OpenSearchRequestTest.java
Show resolved
Hide resolved
astra/src/test/java/com/slack/astra/logstore/opensearch/OpenSearchAdapterTest.java
Outdated
Show resolved
Hide resolved
bryanlb
reviewed
Jul 15, 2024
| // setting lenient=false will not throw error when the query fails to parse against | ||
| // numeric fields | ||
| queryStringQueryBuilder.lenient(false); | ||
| } else { | ||
| // The _all field is the default field for all queries. If we explicitly don't want |
bryanlb
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors query parsing to support all OpenSearch queries by making use of their query parsing libraries. This still maintains support for the old query path should people want to use that, but that path will likely be remove in the near future.
While this doesn't totally resolve our OpenSearch API compatibility issues (see: #798), it does get us remarkably closer
Requirements