respect user provided timestamp #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthacker
force-pushed
the
vthacker_timestamp_handling_bulk_api
branch
from
fb9a7c7 to
3032a5c
Compare
vthacker
force-pushed
the
vthacker_timestamp_handling_bulk_api
branch
from
3032a5c to
75c5084
Compare
bryanlb
requested changes
Jan 29, 2024
kaldb/src/main/java/com/slack/kaldb/bulkIngestApi/opensearch/BulkApiRequestParser.java
Show resolved
Hide resolved
vthacker
force-pushed
the
vthacker_timestamp_handling_bulk_api
branch
from
775a423 to
61145f0
Compare
vthacker
commented
Jan 30, 2024
vthacker
force-pushed
the
vthacker_timestamp_handling_bulk_api
branch
from
61145f0 to
3f70043
Compare
vthacker
commented
Jan 30, 2024
kaldb/src/test/java/com/slack/kaldb/chunkManager/IndexingChunkManagerTest.java
Show resolved
Hide resolved
vthacker
commented
Jan 30, 2024
kaldb/src/test/java/com/slack/kaldb/chunkManager/IndexingChunkManagerTest.java
Show resolved
Hide resolved
bryanlb
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to read several timestamp fields if provided in the ingest document and respect that value instead of always generating the timestamp recorded at ingest time
The main motivation is when logstash sends data it adds a
@timestampfield and we want to respect that value