make the kafka producer single threaded for the OpenSearchBulkIngestApi #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthacker
force-pushed
the
vthacker_make_producer_single_threaded
branch
from
c238777 to
7a2437f
Compare
vthacker
force-pushed
the
vthacker_make_producer_single_threaded
branch
from
7a2437f to
146df94
Compare
vthacker
force-pushed
the
vthacker_make_producer_single_threaded
branch
4 times, most recently
from
3cf0916 to
0aed86f
Compare
vthacker
force-pushed
the
vthacker_make_producer_single_threaded
branch
from
0aed86f to
88a3ca8
Compare
bryanlb
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the current design of OpenSearchBulkIngestApi , we create one transaction producer. This means if every
/_bulkrequest creates it's own thread ( which it does today ) and callsproduceDocumentsthere will be many parallel transactions that we try creating from 1 producer instance.This is not supported by Kafka. So this PR makes the write into kafka single threaded. We will work on a making it the producing to kafka multi-threaded