Use virtual threads for queries #689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthacker
force-pushed
the
vthacker_use_virtual_threads_for_queries
branch
from
93ea3a2 to
e4712ba
Compare
|
Closing as will be superseded by #701 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use virtual threads for query execution.
We don't have a way to set an uncaught exception handler ( #419 (comment) for when it was added ) . But I think we don't need it?
This thread pool is only used for queries, and we already catch all Exceptions? https://github.com/slackhq/kaldb/blob/314a4b0409b2812a30b12eee32aed78fd75358ff/kaldb/src/main/java/com/slack/kaldb/chunkManager/ChunkManagerBase.java#L124-L136
Let's take the example of a CACHE node today. We have 200 chunks that we load onto it in production which means a single query creates 200 threads. Using virtual threads for this can be beneficial.
Once we get this merged, we might want to revisit the number of parallel chunks we can search today. CPU/2 seems low but I know we did some testing back in the day to come up with this.