Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ZK timeout, mark all top-level Kaldb config statics as deprecated #683

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Bump ZK timeout, mark all top-level Kaldb config statics as deprecated #683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions kaldb/src/main/java/com/slack/kaldb/server/KaldbConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,19 @@
* <p>TODO: Set reasonable defaults for the config values.
*/
public class KaldbConfig {

// This should be either moved to a proper config, or likely completely rethought.
// This doesn't make sense as a global for all services, as each service has potentially different
// requirements
// Default start/stop duration for guava services.
public static Duration DEFAULT_START_STOP_DURATION = Duration.ofSeconds(15);
public static final int DEFAULT_ZK_TIMEOUT_SECS = 15;
@Deprecated public static Duration DEFAULT_START_STOP_DURATION = Duration.ofSeconds(15);

// This should go away, in factor of using the zkConnectionTimeoutMs config value
@Deprecated public static final int DEFAULT_ZK_TIMEOUT_SECS = 30;

public static final String CHUNK_DATA_PREFIX = "log";
// This should either be a static final closer to the chunk manager, a config value, or removed
// entirely
@Deprecated public static final String CHUNK_DATA_PREFIX = "log";

private static KaldbConfig _instance = null;

Expand Down