Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to java 21 #678

Merged
merged 9 commits into from
Sep 22, 2023
Merged

Upgrade to java 21 #678

merged 9 commits into from
Sep 22, 2023

Conversation

vthacker
Copy link
Contributor

@vthacker vthacker commented Sep 19, 2023

Summary

Upgrade to Java 21. This change means code will need to be built with Java 21 so your local dev environment needs to have Java 21 as JAVA_HOME when compiling kaldb locally

This PR also explicitly defines the version of bytebuddy being used. The ones that get packaged as a transitive dependency don't have the latest update that works with java 21

From this

. You can always guarantee a version by declaring it explicitly in your project's POM

@vthacker vthacker changed the title WIP: move to java 21 Upgrade to java 21 Sep 20, 2023
@vthacker vthacker force-pushed the java_21 branch 5 times, most recently from 9e019a5 to b0d1d78 Compare September 22, 2023 16:14
@vthacker vthacker marked this pull request as ready for review September 22, 2023 16:16
.github/workflows/maven.yml Outdated Show resolved Hide resolved
.github/workflows/benchmark.yml Show resolved Hide resolved
kaldb/pom.xml Show resolved Hide resolved
@vthacker vthacker merged commit 8ca66cc into master Sep 22, 2023
@vthacker vthacker deleted the java_21 branch September 22, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants