Fix query date parsing in the query nodes #1081
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently we're parsing the query into a
QueryBuilder
, then transforming that into a LuceneQuery
, and then using theQuery::visit
function to extract the start/end time of the query. While this works well enough for certain queries, it requires us to have the full schema in the Query Node ahead of time, and fails any queries that need said schema. Instead, we should use theQueryBuider::visit
functions to recurse through the tree and extract the start/end times as that's far simpler, faster, and doesn't require a full schemaRequirements