Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query date parsing in the query nodes #1081

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

kyle-sammons
Copy link
Collaborator

Summary

Currently we're parsing the query into a QueryBuilder, then transforming that into a Lucene Query, and then using the Query::visit function to extract the start/end time of the query. While this works well enough for certain queries, it requires us to have the full schema in the Query Node ahead of time, and fails any queries that need said schema. Instead, we should use the QueryBuider::visit functions to recurse through the tree and extract the start/end times as that's far simpler, faster, and doesn't require a full schema

Requirements

@ermontross ermontross merged commit ead5138 into master Sep 19, 2024
2 checks passed
@ermontross ermontross deleted the ksammons-fix-query-date-parsing branch September 19, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants