Move fully onto new query parsing #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m:slackhq/kaldb into ksammons-move-full-onto-new-query-parsing
kyle-sammons
changed the title
bryanlb
reviewed
Sep 18, 2024
| @@ -7,12 +7,14 @@ option java_package = "com.slack.astra.proto.service"; | |||
| import "schema.proto"; | |||
|
|
|||
| message SearchRequest { | |||
| // Previously deleted field numbers | |||
bryanlb
approved these changes
Sep 18, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves us fully onto the new query parsing path, removing all of the old cruft. This enables us to be far more flexible with the types of queries that we're accepting (for instance allowing queries with time ranges that don't use
gte/lte), which while technically supported before were blocked by some of our old query path codeRequirements