Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing local docker setup configuration for easier e2e dev testing #1044

Closed
wants to merge 2 commits into from

Conversation

zarna1parekh
Copy link
Contributor

@zarna1parekh zarna1parekh commented Aug 19, 2024

Summary

  • Fixing the local setup configuration to help with dev testing.
  • Added a flag (S3_FORCE_PATH_STYLE) for S3Async client to indicate how to read the buckets.

Requirements

@bryanlb
Copy link
Contributor

bryanlb commented Aug 19, 2024

@zarna1parekh thanks for the contribution! We actually have an existing PR that is currently in draft to completely refactor the object storage. #1030

This isn't quite ready for review yet, but should be within the next day or two. This completely removes all of the existing blob storage in favor of a more targeted implementation that is both significantly faster, and incrementally cheaper to operate. With the pending refactor we will no longer have these classes targeted by this PR as they're entirely removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants