Move buildQuery so that the index searcher is released during excepti…

…on (#989) Co-authored-by: Bryan Burkholder <[email protected]>
slackhq · Jul 12, 2024 · 30a66a0 · 30a66a0
1 parent 1e91dad
commit 30a66a0
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/astra/src/main/java/com/slack/astra/logstore/search/LogIndexSearcherImpl.java b/astra/src/main/java/com/slack/astra/logstore/search/LogIndexSearcherImpl.java
@@ -111,13 +111,12 @@ public SearchResult<LogMessage> search(
       // Acquire an index searcher from searcher manager.
       // This is a useful optimization for indexes that are static.
       IndexSearcher searcher = searcherManager.acquire();
-
-      Query query =
-          openSearchAdapter.buildQuery(
-              dataset, queryStr, startTimeMsEpoch, endTimeMsEpoch, searcher);
       try {
         List<LogMessage> results;
         InternalAggregation internalAggregation = null;
+        Query query =
+            openSearchAdapter.buildQuery(
+                dataset, queryStr, startTimeMsEpoch, endTimeMsEpoch, searcher);
 
         if (howMany > 0) {
           CollectorManager<TopFieldCollector, TopFieldDocs> topFieldCollector =