Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1592 by encoding aiohttp client session pings #1593

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

jasonwbarnett
Copy link
Contributor

@jasonwbarnett jasonwbarnett commented Nov 19, 2024

Summary

Fixes #1592

Testing

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

Copy link

Thanks for the contribution! Before we can merge this, we need @jasonwbarnett to sign the Salesforce Inc. Contributor License Agreement.

@jasonwbarnett
Copy link
Contributor Author

I've already signed the CLA

You already signed the CLA on 2024-11-19

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x socket-mode labels Nov 19, 2024
@seratch seratch added this to the 3.33.4 milestone Nov 19, 2024
@seratch seratch self-assigned this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.92%. Comparing base (6bcf7ec) to head (a4e83ea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1593   +/-   ##
=======================================
  Coverage   84.92%   84.92%           
=======================================
  Files         113      113           
  Lines       12622    12622           
=======================================
  Hits        10719    10719           
  Misses       1903     1903           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking the time to send this PR. Looks great to me; once the CI jobs pass, we will merge it and cut a new patch release.

@seratch seratch changed the title fix: encode aiohttp client session pings Fix #1592 by encoding aiohttp client session pings Nov 19, 2024
@seratch seratch merged commit c3999d6 into slackapi:main Nov 19, 2024
12 checks passed
@jasonwbarnett jasonwbarnett deleted the jwb/fix-ping branch November 19, 2024 01:58
@jasonwbarnett
Copy link
Contributor Author

@seratch thanks for releasing this change so quickly. I've deployed this to production and confirmed it's working as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented cla:signed socket-mode Version: 3x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with socket_mode_handler.connect_async(), not passing bytes to ping w/ aiohttp 3.11
3 participants