Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto pagination #596

Merged
merged 15 commits into from
Aug 6, 2018
Merged

Auto pagination #596

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ec417ab
classifies pagination enabled methods into sets for reflection
aoberoi Jun 3, 2018
ca7b715
Merge branch 'master' into auto-pagination
aoberoi Jun 3, 2018
e9257e7
WIP
aoberoi Jun 5, 2018
cb07fb5
WIP
aoberoi Jul 3, 2018
b413c5b
the slow march of incremental progress (i hope)
aoberoi Jul 25, 2018
0be2796
progress: webclient existing tests passing
aoberoi Jul 25, 2018
99c7842
resolve linting issues
aoberoi Jul 25, 2018
2bc76cd
Merge branch 'master' into auto-pagination
aoberoi Jul 25, 2018
7aefed2
fixes typescript integration tests, add item to lib
aoberoi Jul 25, 2018
6235309
Merge remote-tracking branch 'aoberoi/auto-pagination' into auto-pagi…
aoberoi Jul 25, 2018
219d152
adds tests, includes fixes for reused loggingFunc across instances
aoberoi Aug 1, 2018
6440192
adds new cursor-based pagination methods, adds tests for specific err…
aoberoi Aug 3, 2018
99b27f2
tests for all the pagination warnings
aoberoi Aug 3, 2018
fd5d203
add pageSize config option for WebClient
aoberoi Aug 3, 2018
e28cc36
update documentation for pagination, regenerate docs
aoberoi Aug 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
"docs:jsdoc": "ts2jsdoc"
},
"dependencies": {
"@types/delay": "^2.0.1",
"@types/form-data": "^2.2.1",
"@types/got": "^7.1.7",
"@types/is-stream": "^1.1.0",
Expand All @@ -55,7 +54,6 @@
"@types/retry": "^0.10.2",
"@types/url-join": "^0.8.2",
"@types/ws": "^5.1.1",
"delay": "^2.0.0",
"eventemitter3": "^3.0.0",
"finity": "^0.5.4",
"form-data": "^2.3.1",
Expand All @@ -67,16 +65,16 @@
"object.values": "^1.0.4",
"p-cancelable": "^0.3.0",
"p-queue": "^2.3.0",
"p-retry": "^1.0.0",
"retry": "^0.10.1",
"p-retry": "^2.0.0",
"retry": "^0.12.0",
"url-join": "^4.0.0",
"ws": "^5.2.0"
},
"devDependencies": {
"@aoberoi/capture-console": "^1.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

"@types/chai": "^4.1.2",
"@types/mocha": "^2.2.48",
"busboy": "^0.2.14",
"capture-stdout": "^1.0.0",
"chai": "^4.1.2",
"codecov": "^3.0.0",
"husky": "^0.14.3",
Expand Down
4 changes: 0 additions & 4 deletions src/IncomingWebhook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ export class IncomingWebhook {
/**
* Send a notification to a conversation
* @param message the message (a simple string, or an object describing the message)
* @param callback
*/
public send(message: string | IncomingWebhookSendArguments): Promise<IncomingWebhookResult>;
public send(message: string | IncomingWebhookSendArguments, callback: IncomingWebhookResultCallback): void;
Expand Down Expand Up @@ -75,7 +74,6 @@ export class IncomingWebhook {

/**
* Processes an HTTP response into an IncomingWebhookResult.
* @param response
*/
private buildResult(response: got.Response<string>): IncomingWebhookResult {
return {
Expand Down Expand Up @@ -147,7 +145,6 @@ function requestErrorWithOriginal(original: Error): IncomingWebhookRequestError
return (error as IncomingWebhookRequestError);
}


/**
* A factory to create IncomingWebhookReadError objects
* @param original The original error
Expand All @@ -161,7 +158,6 @@ function readErrorWithOriginal(original: Error): IncomingWebhookReadError {
return (error as IncomingWebhookReadError);
}


/**
* A factory to create IncomingWebhookHTTPError objects
* @param original The original error
Expand Down
1 change: 0 additions & 1 deletion src/KeepAlive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ export class KeepAlive extends EventEmitter {

/**
* Start monitoring the RTMClient. This method should only be called after the client's websocket is already open.
* @param client an RTMClient to monitor
*/
public start(client: RTMClient): void {
this.logger.debug('start monitoring');
Expand Down
4 changes: 0 additions & 4 deletions src/RTMClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,6 @@ export class RTMClient extends EventEmitter {
/**
* Begin an RTM session using the provided options. This method must be called before any messages can
* be sent or received.
* @param options arguments for the start method
*/
public start(options?: methods.RTMStartArguments | methods.RTMConnectArguments): void {
// TODO: should this return a Promise<WebAPICallResult>?
Expand Down Expand Up @@ -541,7 +540,6 @@ export class RTMClient extends EventEmitter {

/**
* Set up method for the client's websocket instance. This method will attach event listeners.
* @param url the websocket url
*/
private setupWebsocket(url: string): void {
// initialize the websocket
Expand Down Expand Up @@ -579,7 +577,6 @@ export class RTMClient extends EventEmitter {
/**
* `onmessage` handler for the client's websocket. This will parse the payload and dispatch the relevant events for
* each incoming message.
* @param websocketMessage an incoming message
*/
private onWebsocketMessage({ data }: { data: string }): void {
// v3 legacy
Expand Down Expand Up @@ -677,7 +674,6 @@ export interface RTMWebsocketError extends CodedError {

/**
* A factory to create RTMWebsocketError objects.
* @param original the original error
*/
function websocketErrorWithOriginal(original: Error): RTMWebsocketError {
const error = errorWithCode(
Expand Down
Loading