Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (web-api): tweak type of reply_broadcast to be wider #1860

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Jul 31, 2024

...to allow for wider boolean usage with it. fixes #1859

@filmaj filmaj added semver:patch area:typescript issues that specifically impact using the package from typescript projects pkg:web-api applies to `@slack/web-api` labels Jul 31, 2024
@filmaj filmaj requested a review from a team July 31, 2024 13:13
@filmaj filmaj self-assigned this Jul 31, 2024
Copy link
Contributor

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test and change LGTM! 🙌

@filmaj filmaj added this to the [email protected] milestone Jul 31, 2024
@filmaj filmaj merged commit 20491c8 into main Jul 31, 2024
28 checks passed
@filmaj filmaj deleted the web-api-reply-broadcast-type-fix branch July 31, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:typescript issues that specifically impact using the package from typescript projects pkg:web-api applies to `@slack/web-api` semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting reply_broadcast gives a type error when it's a dynamic value
2 participants