Skip to content

Commit

Permalink
ci: lock to node 22.4.x when running on node 22; fixes npm issues w/ …
Browse files Browse the repository at this point in the history
…node 22.5.x (#1847)
  • Loading branch information
Fil Maj authored Jul 19, 2024
1 parent ea00fc6 commit 4e9c7a7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/ci-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [18.x, 20.x, 22.x]
node-version: [18.x, 20.x, 22.4.x]
package:
- cli-hooks
- cli-test
Expand All @@ -30,12 +30,13 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm --version
- name: Get Development Dependencies
run: npm i
- name: Build and Run Tests in Each Package
working-directory: packages/${{ matrix.package }}
run: |
npm install || npm list
npm install
# depending on which package we are testing, also npm link up other dependent packages
case "$PWD" in
*/webhook) pushd ../types && npm i && popd && npm link ../types;;
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "node-slack-sdk",
"devDependencies": {
"eslint": "^7.32.0",
"eslint-plugin-jsdoc": "^30.6.1"
"eslint": "^8.47.0",
"eslint-plugin-jsdoc": "^46.5.0"
}
}

0 comments on commit 4e9c7a7

Please sign in to comment.