Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OAuth flow to complete with some cases #455

Merged
merged 2 commits into from
May 18, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented May 18, 2020

Summary

This pull request improves the OAuth flow handling in the following cases:

  • No exception when team in oauth.v2.access response is missing
  • redirect_uri is not used

Requirements (place an x in each [ ])

* No exception when team in oauth.v2.access response is missing
* redirect_uri is not used
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #455 into master will increase coverage by 0.02%.
The diff coverage is 73.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #455      +/-   ##
============================================
+ Coverage     83.64%   83.66%   +0.02%     
- Complexity     2386     2388       +2     
============================================
  Files           250      250              
  Lines          6438     6442       +4     
  Branches        586      590       +4     
============================================
+ Hits           5385     5390       +5     
+ Misses          694      690       -4     
- Partials        359      362       +3     
Impacted Files Coverage Δ Complexity Δ
...uth/default_impl/OAuthV2DefaultSuccessHandler.java 85.41% <60.00%> (-3.72%) 8.00 <0.00> (ø)
...slack/api/app_backend/oauth/OAuthFlowOperator.java 88.88% <80.00%> (-11.12%) 3.00 <2.00> (ø)
...i/methods/metrics/impl/MemoryMetricsDatastore.java 92.25% <0.00%> (+0.70%) 42.00% <0.00%> (+1.00%)
...pi/methods/metrics/impl/RedisMetricsDatastore.java 89.50% <0.00%> (+2.46%) 38.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39fb84a...79a3cb2. Read the comment docs.

@seratch seratch merged commit 7913e7b into slackapi:master May 18, 2020
@seratch seratch deleted the no-team-no-redirect-uri branch May 18, 2020 11:17
seratch added a commit that referenced this pull request May 28, 2020
* [slack-api-model] Add missing fields in objects (confirm.style in blocks, user.is_invited_user: boolean, message.hidden, Slack post related fields in file objects) - thanks @seratch
* [slack-api-client etc] #466 #462 Calls API support - thanks @seratch
* [slack-api-client] #475 #474 Make redirect_uri for oauth.access / oauth.v2.access optional - thanks @natevaughan @seratch
* [slack-api-client] #476 Bump dependencies (okhttp, micronaut, tyrus-standalone-client) - thanks @seratch
* [slack-api-client] #459 Adding ping message and pong event to RTM client - thanks @gaspardpetit
* [slack-api-client] #451 Add support and check for the event subtypes in RTM client - thanks @gaspardpetit
* [bolt] #455 Improve OAuth flow module to consider the cases where team is missing in oauth.v2.access responses - thanks @seratch
* [bolt] #476 Bump dependencies (aws-java-sdk-s3) - thanks @seratch
emanguy pushed a commit to emanguy/java-slack-sdk that referenced this pull request Jun 22, 2020
* [slack-api-model] Add missing fields in objects (confirm.style in blocks, user.is_invited_user: boolean, message.hidden, Slack post related fields in file objects) - thanks @seratch
* [slack-api-client etc] slackapi#466 slackapi#462 Calls API support - thanks @seratch
* [slack-api-client] slackapi#475 slackapi#474 Make redirect_uri for oauth.access / oauth.v2.access optional - thanks @natevaughan @seratch
* [slack-api-client] slackapi#476 Bump dependencies (okhttp, micronaut, tyrus-standalone-client) - thanks @seratch
* [slack-api-client] slackapi#459 Adding ping message and pong event to RTM client - thanks @gaspardpetit
* [slack-api-client] slackapi#451 Add support and check for the event subtypes in RTM client - thanks @gaspardpetit
* [bolt] slackapi#455 Improve OAuth flow module to consider the cases where team is missing in oauth.v2.access responses - thanks @seratch
* [bolt] slackapi#476 Bump dependencies (aws-java-sdk-s3) - thanks @seratch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant