Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1348 channel_convert_to_public message events #1388

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

seratch
Copy link
Member

@seratch seratch commented Oct 15, 2024

This pull request resolves #1348

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:bolt project:slack-api-model project:slack-api-model project:slack-app-backend labels Oct 15, 2024
@seratch seratch added this to the 1.44.0 milestone Oct 15, 2024
@seratch seratch self-assigned this Oct 15, 2024
@@ -1,7 +1,6 @@
package com.slack.api.app_backend.events.payload;

import com.slack.api.model.event.SharedChannelInviteReceivedEvent;
import com.slack.api.model.event.TeamJoinEvent;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused import

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.72%. Comparing base (83b8e1b) to head (58ea6c2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../handler/MessageChannelConvertToPublicHandler.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1388   +/-   ##
=========================================
  Coverage     74.71%   74.72%           
- Complexity     4337     4338    +1     
=========================================
  Files           472      473    +1     
  Lines         13506    13509    +3     
  Branches       1378     1378           
=========================================
+ Hits          10091    10094    +3     
  Misses         2604     2604           
  Partials        811      811           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch merged commit e033580 into slackapi:main Oct 15, 2024
5 of 6 checks passed
@seratch seratch deleted the issue-1348 branch October 15, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:bolt project:slack-api-model project:slack-api-model project:slack-app-backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No event class for channel_convert_to_public
1 participant