Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating app_requested payload to include new field #1355

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

gugutagli
Copy link
Contributor

Updating app_requested payload to include is_granular_bot_app

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@filmaj filmaj requested a review from seratch August 30, 2024 17:54
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Java class needs to be updated and you can run the unit test that auto-generates the sample JSON file: https://github.com/slackapi/java-slack-sdk/blob/main/slack-api-model/src/main/java/com/slack/api/model/admin/AppRequest.java

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-model project:slack-api-model labels Aug 30, 2024
@seratch seratch added this to the 1.42.1 milestone Aug 30, 2024
@gugutagli
Copy link
Contributor Author

This Java class needs to be updated and you can run the unit test that auto-generates the sample JSON file: https://github.com/slackapi/java-slack-sdk/blob/main/slack-api-model/src/main/java/com/slack/api/model/admin/AppRequest.java

Thank you, I was able to add to the java file. This is my first time working on this, which test do I run and how do I run them?

@@ -12,6 +12,7 @@ public class App {
private String privacyPolicyUrl;
private String appHomepageUrl;
private String appDirectoryUrl;
@SerializedName("is_granular_bot_app")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@SerializedName("is_granular_bot_app")
@SerializedName("is_granular_bot_app")
private boolean granularBotApp

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this flag can be absent in some patterns, private Boolean isGranularBotApp without SerializedName annotation is suitable.

@seratch
Copy link
Member

seratch commented Aug 31, 2024

@gugutagli You can run this script for it, but it may take time. For this specific pull request, running only this test should be fine.

@seratch seratch force-pushed the gt-update-app-requested-payload branch from f8e5fee to 17a68dc Compare September 2, 2024 02:43
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.81%. Comparing base (d8b4d6e) to head (1fe5ec6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1355      +/-   ##
============================================
- Coverage     74.87%   74.81%   -0.06%     
+ Complexity     4275     4273       -2     
============================================
  Files           457      457              
  Lines         13276    13276              
  Branches       1369     1369              
============================================
- Hits           9940     9933       -7     
- Misses         2537     2545       +8     
+ Partials        799      798       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch merged commit 4041350 into main Sep 2, 2024
6 checks passed
@seratch seratch deleted the gt-update-app-requested-payload branch September 2, 2024 03:35
@seratch
Copy link
Member

seratch commented Sep 2, 2024

@gugutagli Thanks for sending this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:slack-api-model project:slack-api-model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants