-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating app_requested payload to include new field #1355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Java class needs to be updated and you can run the unit test that auto-generates the sample JSON file: https://github.com/slackapi/java-slack-sdk/blob/main/slack-api-model/src/main/java/com/slack/api/model/admin/AppRequest.java
Thank you, I was able to add to the java file. This is my first time working on this, which test do I run and how do I run them? |
@@ -12,6 +12,7 @@ public class App { | |||
private String privacyPolicyUrl; | |||
private String appHomepageUrl; | |||
private String appDirectoryUrl; | |||
@SerializedName("is_granular_bot_app") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SerializedName("is_granular_bot_app") | |
@SerializedName("is_granular_bot_app") | |
private boolean granularBotApp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this flag can be absent in some patterns, private Boolean isGranularBotApp
without SerializedName annotation is suitable.
@gugutagli You can run this script for it, but it may take time. For this specific pull request, running only this test should be fine. |
f8e5fee
to
17a68dc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1355 +/- ##
============================================
- Coverage 74.87% 74.81% -0.06%
+ Complexity 4275 4273 -2
============================================
Files 457 457
Lines 13276 13276
Branches 1369 1369
============================================
- Hits 9940 9933 -7
- Misses 2537 2545 +8
+ Partials 799 798 -1 ☔ View full report in Codecov by Sentry. |
@gugutagli Thanks for sending this PR! |
Updating
app_requested
payload to includeis_granular_bot_app
Category (place an
x
in each of the[ ]
)Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.