Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add botScopes and requestUserScopes to context object #1144

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented Apr 26, 2023

This pull request adds botScopes and requestUserScopes to context object in the same way with slackapi/bolt-python#855

While testing this new feauture, I found that the logic to set context.requestUserId can be improved for Events API patterns. I will make changes for it in a different pull request.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:bolt labels Apr 26, 2023
@seratch seratch added this to the 1.30.0 milestone Apr 26, 2023
@seratch seratch self-assigned this Apr 26, 2023
@seratch seratch force-pushed the scopes-in-context branch from 503862b to 22366d7 Compare April 26, 2023 09:27
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #1144 (22366d7) into main (f02885e) will decrease coverage by 0.09%.
The diff coverage is 47.61%.

@@             Coverage Diff              @@
##               main    #1144      +/-   ##
============================================
- Coverage     75.84%   75.76%   -0.09%     
- Complexity     3828     3830       +2     
============================================
  Files           415      415              
  Lines         11907    11923      +16     
  Branches       1182     1191       +9     
============================================
+ Hits           9031     9033       +2     
- Misses         2165     2174       +9     
- Partials        711      716       +5     
Impacted Files Coverage Δ
.../main/java/com/slack/api/bolt/context/Context.java 75.00% <ø> (ø)
...lt/middleware/builtin/SingleTeamAuthorization.java 83.33% <46.15%> (-8.98%) ⬇️
...lt/middleware/builtin/MultiTeamsAuthorization.java 55.75% <50.00%> (-0.30%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit e8113b3 into slackapi:main Apr 28, 2023
@seratch seratch deleted the scopes-in-context branch April 28, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:bolt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant