Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group from SCIM is not according to the actual response #409

Closed
2 of 7 tasks
TarasPavliuchyn opened this issue Mar 30, 2020 · 3 comments · Fixed by #411
Closed
2 of 7 tasks

Group from SCIM is not according to the actual response #409

TarasPavliuchyn opened this issue Mar 30, 2020 · 3 comments · Fixed by #411
Assignees
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client

Comments

@TarasPavliuchyn
Copy link

Issue Type

TODO:
Place an x in one of the [ ].

  • Bug
  • Enhancement / Feature request
  • Question
  • Documentation

Description

com.slack.api.scim.SCIMClient#searchUsers() returns users with groups where all fields are empty.
The problem is in wrong filed names in com.slack.api.scim.model.Group . Actual HTTP response looks like (from slackHttpClient):

{
// skipped text
"groups": [{
"value": "XXXXXXX",
"display": "Awesome Group"
}]
}]
}

So Gson can't parse it to com.slack.api.scim.model.Group correctly. As a result all fields are null.

The issue is reproducible in:

  • Module Version: com.slack.api:slack-api-client:1.0.0-M1 and above
  • JDK Version: openjdk version "1.8.0_222"

The steps to reproduce are:

  1. Run com.slack.api.scim.SCIMClient#searchUsers()for users that assigned to the group.

The expected result is:
At least I expect to see 'display' attribute.

The actual result is:
All fields in Group are empty.

TODO:

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@seratch seratch self-assigned this Mar 31, 2020
@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client labels Mar 31, 2020
seratch added a commit to seratch/java-slack-sdk that referenced this issue Mar 31, 2020
@seratch
Copy link
Member

seratch commented Mar 31, 2020

@TarasPavliuchyn I've fixed the bug by #411. I'm going to release a new patch version within a few hours. Thanks for reporting the issue and I'm sorry for the inconvenience.

seratch added a commit to seratch/java-slack-sdk that referenced this issue Mar 31, 2020
seratch added a commit that referenced this issue Mar 31, 2020
Fix #409 by adding valid response structure - user.groups
seratch added a commit that referenced this issue Mar 31, 2020
* [slack-api-client] Fix #409 Group from SCIM is not according to the actual response - Thanks @MMotta-zAgile
* [slack-api-model] Fix #410 Hint for a Modal Surface's Input block - Thanks @TarasPavliuchyn
* [slack-api-client] Bump okhttp patch version from 4.4.0 to 4.4.1 square/okhttp@parent-4.4.0...parent-4.4.1 - Thanks @seratch
@seratch
Copy link
Member

seratch commented Mar 31, 2020

Thank you very much again for taking the time to report this. A new version - 1.0.2 is out now. Please try it out when you have a chance.

@TarasPavliuchyn
Copy link
Author

Thank you for the fast fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants