change deprecated usage of res.send #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #487 +/- ##
=======================================
Coverage 84.23% 84.23%
=======================================
Files 7 7
Lines 552 552
Branches 163 163
=======================================
Hits 465 465
Misses 60 60
Partials 27 27
Continue to review full report at Codecov.
|
seratch
approved these changes
Apr 27, 2020
| @@ -108,7 +108,7 @@ export default class ExpressReceiver implements Receiver { | |||
| this.logger.debug('stored response sent'); | |||
| } | |||
| } catch (err) { | |||
| res.send(500); | |||
| res.status(500).send(); | |||
There was a problem hiding this comment.
Although the warning message suggests to use res.sendStatus(status), I prefer your change. In this case, a Slack app doesn't need to send any data in response body.
|
Your change looks good to me. I will wait for responses from other maintainers for a few business days before merging it. Thanks for fixing this! |
stevengill
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Small fix to replace deprecated usage of
res.send();for status codes.Currently, a deprecation warning will get propagated down to bolt users if they hit this catch block.
Requirements (place an
xin each[ ])