Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Shortcut Method #427

Merged
merged 5 commits into from
Mar 18, 2020
Merged

Added Shortcut Method #427

merged 5 commits into from
Mar 18, 2020

Conversation

stevengill
Copy link
Member

@stevengill stevengill commented Mar 16, 2020

Summary

Added new shortcut method

Todo:

  • Docs
  • Tests

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #427 into master will decrease coverage by 1.73%.
The diff coverage is 26.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
- Coverage   81.50%   79.77%   -1.74%     
==========================================
  Files           7        7              
  Lines         530      544      +14     
  Branches      152      158       +6     
==========================================
+ Hits          432      434       +2     
- Misses         70       80      +10     
- Partials       28       30       +2     
Impacted Files Coverage Δ
src/App.ts 83.91% <25.00%> (-3.06%) ⬇️
src/middleware/builtin.ts 80.62% <25.00%> (-1.78%) ⬇️
src/helpers.ts 86.20% <33.33%> (-6.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bfd4f8...fd70de4. Read the comment docs.

type: 'shortcut';
callback_id: string;
trigger_id: string;
user: {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated based on feedback from @shaydewael

Copy link
Contributor

@aoberoi aoberoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aweeesomemeee

@stevengill stevengill merged commit 93ec1da into slackapi:master Mar 18, 2020
@stevengill stevengill deleted the shortcut branch March 18, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants